• IM_MULTIPLYING_RESULT_OF_IREM

“The code multiplies the result of an integer remaining by an integer constant. Be sure you don't have your operator precedence confused. For example i % 60 * 1000 is (i % 60) * 1000, not i % (60 * 1000).”

For Java remainders and multiplications are on the same level when it comes to operator precedence (i.e. whatever term stands further left is computed first). That might be not very intuitive or widely known and can therefore lead to errors. Programmers should always indicate the order they want to have using parentheses.

<code Java>

public static void main(String []args) {

	    	int i=230;
	       System.out.println(i % 60 * 1000); 
	    }
	 

</Code>

<code Java>

public static void main(String []args) {

	    	int i=230;
	       System.out.println("i % 60 * 1000");
                     System.out.println(60 % 1000); 
                     System.out.println(i * 60);
                     System.out.println(i * 60 + 1000);
                     System.out.println(i * (60 % 1000));    
	    }
	 

</Code>

It's hard to provide a fix since it is not sure what the programmer wants. In any case she should specify the operations using Parentheses. One of the following “fixes” can be applied: <code Java>

            public static void main(String []args) {
	    	int i=230;
	       System.out.println((i % 60) * 1000); 
	    }

</Code> <code Java>

            public static void main(String []args) {
	    	int i=230;
	       System.out.println(i % (60 * 1000)); 
	    }

</Code>

FB = FindBugs, JT = JTransformer, Delta = JTransformer - FindBug

All measurements were taken on a machine with the following properties:

• JT Version: 4.0.0
• Eclipse Kepler
• Windows 8.1
• i5 2,30Ghz
• 8 GB Main Memory
• SSD Hardrive